Fix Saxon-HE 12 trailing newline issue in XML serialization #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps net.sf.saxon:Saxon-HE from 9.6.0-7 to 12.7. --- updated-dependencies: - dependency-name: net.sf.saxon:Saxon-HE dependency-version: '12.7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
When Saxon-HE is upgraded to version 12.x, it adds a trailing newline to XML output when indenting is enabled. This breaks backward compatibility with tests expecting the output format from Saxon 9.6. The fix trims the trailing newline in DomUtils.asXml() when indenting is enabled, maintaining consistent output across Saxon versions. Fixes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the trailing newline issue that occurs when upgrading Saxon-HE from 9.6.0-7 to 12.7.
Problem
Saxon 12 adds a trailing newline character to XML output when indenting is enabled, which wasn't present in Saxon 9.6. This breaks existing tests and changes the output format unexpectedly.
Solution
Modified
DomUtils.asXml()to trim the trailing newline when indenting is enabled. This maintains backward compatibility and ensures consistent output across all Saxon versions.Changes
DomUtils.asXml(Node, boolean, Map<String,String>)to remove trailing newline when indent is trueTesting
Fixes #22